Fix issue where glyphs were renderered as outlines

[adamnemecek]

Closes #18

I came across this while trying out the canvas_nanovg example in pathfinder.

The glyphs were rendered like this

This is the result after this patch:

Credit goes to @jeroentervoorde and @Stoeoef, who figured this out.

Links:
servo/pathfinder#194
fschutt/azul#125 (comment)

[raphlinus]

I'm confused, the linked HB doc suggests that the funcs are already set by default. Looking at the HB source, it seems like they are, unless HB_NO_OT_FONT is set. Do we think the Rust HB build is setting that symbol?

[RazrFalcon]

@raphlinus Unless they are using harfbuzz < 2.0. For example, Ubuntu 18.04 uses 1.7.2.

[adamnemecek]

The rust harfbuzz bindings use 2.6.4.

[raphlinus]

Thanks @RazrFalcon, that really helps clear up my confusion. If I understand it, the crate is designed to dynamically link the system HarfBuzz when available, but statically build when not? That would explain diversity of behavior. It's also potentially a very serious problem if we want to depend on newer behavior.

In any case, do you think this is a good fix?

[RazrFalcon]

@adamnemecek It uses system one on linux. You have to set HARFBUZZ_SYS_NO_PKG_CONFIG=1 to opt it.

[RazrFalcon]

@raphlinus Personally, I think using HARFBUZZ_SYS_NO_PKG_CONFIG=1 to always use the embedded version is preferred. I've already had strange bugs in resvg because of relying on a system version.

[raphlinus]

Right, I agree. There's just way too much that can go wrong. Adam, would you be willing to make that PR?

[adamnemecek]

I can give it a shot. That would be a different PR right?

…

On Fri, Jul 17, 2020 at 11:36 Raph Levien ***@***.***> wrote: Right, I agree. There's just way too much that can go wrong. Adam, would you be willing to make that PR? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABMRD6XSHBZ56FKUBO3Z7TR4CK2NANCNFSM4O6VAKOQ> .