-
Notifications
You must be signed in to change notification settings - Fork 23
Add AVX-512 support #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add AVX-512 support #231
Changes from all commits
92bfd8a
f08f7e6
aef1cac
c12a7cc
9d9adf8
81441cf
0d6af5d
025c172
7927383
57de129
2630928
f2ba8c9
9cddbb2
9d02c3a
85b44c9
1c558ca
6c8f7d7
e475ae1
6f1081f
1e2a096
7fc16d4
359650d
37df3e3
8825bfb
cf3ff7d
cb5780f
f55271b
cd8192c
15f5ab8
6233743
88bc247
608b53f
d45b511
b03927f
fa81bb8
b5de7ff
0c9535b
ec42970
a593499
9ec500c
3a5310a
73e5c96
9c91523
815ce03
2b7fe3a
3c4bcbc
2d0595d
0847ebf
672772f
1887405
6e5672a
dc4c8fe
ce28db9
ca1759b
484d1bf
7efdb1a
014e4b7
9d4f115
d49f6a2
00eb81d
046ee30
70e489b
a5f1b3a
490f83b
a234432
6d5f4ed
cf18ec3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,6 +15,8 @@ cargo check -p fearless_simd --target aarch64-linux-android --features force_su | |
| cargo check -p fearless_simd --target aarch64-linux-android | ||
|
|
||
| # x86_64, at all supported static SIMD levels. | ||
| RUSTFLAGS=-Ctarget-cpu=icelake-server cargo check -p fearless_simd --target x86_64-unknown-linux-gnu | ||
| RUSTFLAGS=-Ctarget-cpu=icelake-server cargo check -p fearless_simd --target x86_64-unknown-linux-gnu --features force_support_fallback | ||
|
Comment on lines
+18
to
+19
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not just set the AVX512 feature flags here, like below? Also, do we need to update the commands below to activate all feature flags that were added to SSE4.2/AVX2 a while ago?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess it makes sense to keep it shorter, but the invocations below probably need to be updated (in a follow-up), no? Since they are missing the other target features we require. Or am I missing something?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. oh yeah I missed that script, it does need updating for v2/v3 targets, good call |
||
| RUSTFLAGS=-Ctarget-feature=+avx2,+fma cargo check -p fearless_simd --target x86_64-unknown-linux-gnu | ||
| RUSTFLAGS=-Ctarget-feature=+avx2,+fma cargo check -p fearless_simd --target x86_64-unknown-linux-gnu --features force_support_fallback | ||
| RUSTFLAGS=-Ctarget-feature=+sse4.2 cargo check -p fearless_simd --target x86_64-unknown-linux-gnu | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would changing the MSRV from 1.88 to 1.89 impact this then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Clippy is run on MSRV instead of latest stable on CI.
We could probably switch it to latest stable now that it respects the crate MSRV, but that would randomly cause CI to fail on main because of Clippy adding new lints in later releases, and dealing with that is rather miserable in my experience.