Skip to content

Provide standard highdicom #454 Frame UID patch with bytewise verification - #29

Merged
lindicaphxag-tech merged 4 commits into
mainfrom
research/highdicom-454-upstream-unified-diff
Oct 8, 2026
Merged

lindicaphxag-tech merged 4 commits into
mainfrom
research/highdicom-454-upstream-unified-diff

Conversation

@lindicaphxag-tech

Copy link
Copy Markdown
Owner

One maintainer-native patch, no ClinGeom dependency

This PR stages an actual, conventional unified diff for the pinned highdicom #454 MONAI bridge.

The concrete failure

On the exact public highdicom #454 head 4524bb0b0c8b3141f6f5b26d047b8da43c69e61e, an automatic Volume -> MetaTensor -> Volume round-trip preserves affine numerically (max error 0.0) but drops highdicom's FrameOfReferenceUID. Two Volumes with distinct UIDs but equal affine become indistinguishable in that metadata field; an explicit frame_of_reference_uid argument works.

Patch

Only src/highdicom/volume.py: two insertion sites, no new dependency, no geometry conversion change:

  • to_monai() saves a known UID to a namespaced metadata field;
  • from_monai() uses it only if caller's explicit UID is None.

Independent evidence

  • Existing paired runtime CI already passes on the pinned source with the Python patch script and checks preserved UID/explicit override/legacy metadata/RAS-LPS affine round-trip.
  • This PR adds highdicom_454_frame_uid.patch and a separate lightweight CI that checks git apply --check on exact upstream, applies the patch, and byte-compares it with the already-tested Python patch result.
  • Full copy/paste application instructions and evidence boundary in HIGHDICOM_454_UPSTREAM_PATCH.md.

Not claimed: an upstream PR, highdicom maintainer approval, independent external adoption or clinical safety. Third-party GitHub mutation remains blocked with HTTP 403; this public patch is staged for human-authenticated upstream submission or reviewer feedback.

This is deliberately a narrow upstream compatibility fix, not a request to adopt the broader ClinGeom research system.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@lindicaphxag-tech
lindicaphxag-tech merged commit 096f718 into main Oct 8, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants