Repository navigation
Provide standard highdicom #454 Frame UID patch with bytewise verification - #29
Merged
lindicaphxag-tech merged 4 commits intoOct 8, 2026
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One maintainer-native patch, no ClinGeom dependency
This PR stages an actual, conventional unified diff for the pinned highdicom #454 MONAI bridge.
The concrete failure
On the exact public highdicom #454 head
4524bb0b0c8b3141f6f5b26d047b8da43c69e61e, an automaticVolume -> MetaTensor -> Volumeround-trip preserves affine numerically (max error 0.0) but drops highdicom'sFrameOfReferenceUID. Two Volumes with distinct UIDs but equal affine become indistinguishable in that metadata field; an explicitframe_of_reference_uidargument works.Patch
Only
src/highdicom/volume.py: two insertion sites, no new dependency, no geometry conversion change:to_monai()saves a known UID to a namespaced metadata field;from_monai()uses it only if caller's explicit UID isNone.Independent evidence
highdicom_454_frame_uid.patchand a separate lightweight CI that checksgit apply --checkon exact upstream, applies the patch, and byte-compares it with the already-tested Python patch result.HIGHDICOM_454_UPSTREAM_PATCH.md.Not claimed: an upstream PR, highdicom maintainer approval, independent external adoption or clinical safety. Third-party GitHub mutation remains blocked with HTTP 403; this public patch is staged for human-authenticated upstream submission or reviewer feedback.
This is deliberately a narrow upstream compatibility fix, not a request to adopt the broader ClinGeom research system.