Repository navigation
ClinGeom: execute pinned highdicom #454 frame-identity witness - #10
Merged
Merged
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Turn the source-audited highdicom #454 FrameOfReferenceUID gap into a public, pinned, executable witness.
Frozen runtime
4524bb0b0c8b3141f6f5b26d047b8da43c69e61e1.6.1Expected witness
The same run must show:
FrameOfReferenceUIDdoes not round-trip;frame_of_reference_uidrestores the identity.The workflow uploads the JSON witness as an Actions artifact.
Claim boundary
This is a public execution witness against a pinned open PR head. It is not maintainer confirmation, upstream adoption, or a claim that highdicom has accepted this diagnosis.
Executed result
Public Actions run: https://github.com/lindicaphxag-tech/kaggle/actions/runs/37475115875
Pinned execution result:
{ "geometry_roundtrip_max_abs_error": 0.0, "automatic_roundtrip_uid_a": null, "automatic_roundtrip_uid_b": null, "automatic_uid_preserved": false, "explicit_uid_preserved": true, "same_meta_affine_for_distinct_source_uids": true }The uploaded artifact digest is:
sha256:7d5ff2768428049acf40f1e70292cbfb83de9cbbcb420b34b070ad91fd1297f4Interpretation: numerical voxel-to-world geometry round-trips exactly on this witness, while DICOM physical-frame identity is not automatically carried through the current pinned Volume ↔ MetaTensor bridge. Explicit caller-supplied identity still works.
This remains a public execution witness, not upstream maintainer confirmation.
Persistent review artifacts
research/medical_geometry/upstream_repros/HIGHDICOM_454_RESULT.mdresearch/medical_geometry/upstream_repros/HIGHDICOM_454_PATCH_PROPOSAL.mdresearch/medical_geometry/upstream_repros/highdicom_454_frame_identity.pyThese are intentionally kept independent of the ClinGeom method claims so an upstream reviewer can evaluate the interoperability issue without adopting ClinGeom.