Implements iterative binary search in Search.binary(). - #14
Open
Kimmicorn-glitch wants to merge 1 commit into
Open
Implements iterative binary search in Search.binary().#14Kimmicorn-glitch wants to merge 1 commit into
Kimmicorn-glitch wants to merge 1 commit into
Conversation
Kimmicorn-glitch
commented
Oct 19, 2025
- Returns index if found, NotFoundError object if not.
- Handles edge cases: empty list, single element, first/last element.
- Optimized for large datasets.
Implemented binary search algorithm in the binary method.
Owner
|
@Kimmicorn-glitch, your implementation works, and I have marked it as |
Author
|
Oh,I apologize for removing them. Thank you for pointing that out, I took
them out because the functions seemed pretty simple, but I didn’t mean to
overlook anything important. I can add them back if that’s better for
consistency.
…On Mon, Oct 20, 2025 at 8:13 AM Nqabenhle ***@***.***> wrote:
*lindelwa122* left a comment (lindelwa122/sort-quest#14)
<#14 (comment)>
@Kimmicorn-glitch <https://github.com/Kimmicorn-glitch>, your
implementation works, and I have marked it as hacktoberfest-accepted. But
I am just curious, why did you remove the docstrings?
—
Reply to this email directly, view it on GitHub
<#14 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BVVD73EPV5GEQC6CEAXPQ433YR4PZAVCNFSM6AAAAACJTKHBVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMRQG4YDGNJTGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Owner
|
@Kimmicorn-glitch, no it's okay, I just wanted to find out your reasoning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.