feat(multi-line): Allow multi-lines in Range-cards include empty lines. - #56
Open
ikozhma wants to merge 1 commit into
Open
feat(multi-line): Allow multi-lines in Range-cards include empty lines.#56ikozhma wants to merge 1 commit into
ikozhma wants to merge 1 commit into
Conversation
Owner
|
Hi, thanks for the PR! I have a concern about backward compatibility. I tried the case: The old implementation found 2 patterns, but the new one found 1 pattern. I may need some time to think about this PR. If you have any ideas, feel free to talk. |
Contributor
Author
|
@linanwx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Range card didn't allow multiline patterns to include empty lines
Example1:
The parsed card will be
line2 ? line3whileline1andline4are cut out.Now all lines are included and the card will look like exactly as it is written.
I checked that this change interacts gracefully with sub-cards splitters.
As they have priority over multi-lining.