Skip to content

Standardize HTML sanitizing when preview email#3223

Merged
hoangdat merged 9 commits into
masterfrom
hotfix/sanitize_html
Oct 24, 2024
Merged

Standardize HTML sanitizing when preview email#3223
hoangdat merged 9 commits into
masterfrom
hotfix/sanitize_html

Conversation

@dab246

@dab246 dab246 commented Oct 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@dab246
dab246 requested a review from hoangdat October 23, 2024 08:29
@dab246
dab246 force-pushed the hotfix/sanitize_html branch from edddd1a to 94e2c31 Compare October 23, 2024 08:32
@github-actions

github-actions Bot commented Oct 23, 2024

Copy link
Copy Markdown

This PR has been deployed to https://linagora.github.io/tmail-flutter/3223.

@dab246
dab246 force-pushed the hotfix/sanitize_html branch from 94e2c31 to f64cc96 Compare October 23, 2024 08:53
chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
Comment thread contact/pubspec.lock Outdated
chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
Comment thread contact/pubspec.lock
@dab246
dab246 requested a review from chibenwa October 23, 2024 09:29
@hoangdat

hoangdat commented Oct 23, 2024 •
edited by dab246
Loading

Copy link
Copy Markdown
Member
  • inline image was not display
Screenshot 2024-10-23 at 16 28 40

chibenwa
chibenwa reviewed Oct 23, 2024
View reviewed changes
Comment thread core/pubspec.yaml
@hoangdat

hoangdat commented Oct 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@dab246

dab246 commented Oct 23, 2024

Copy link
Copy Markdown
Member Author
  • inline image was not display
Screenshot 2024-10-23 at 16 28 40

Fixed

Screen.Recording.2024-10-23.at.19.06.22.mov
  • in Android, this email is not fit as before
    Uploading ⛳ Tous les coups comptent ! 😄.eml.zip…

Before and after applying sanitize html nothing changes. The actual width of the email is larger than the screen width so it will allow horizontal scrolling.

demo.webm

@dab246
dab246 requested review from chibenwa and hoangdat October 23, 2024 12:18
@hoangdat

hoangdat commented Oct 23, 2024 •
edited by dab246
Loading

Copy link
Copy Markdown
Member
  • should migrate db (...)

@dab246

dab246 commented Oct 24, 2024

Copy link
Copy Markdown
Member Author
  • should migrate db (...)

Updated

@dab246

dab246 commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Fixed

demo.webm

@hoangdat

hoangdat commented Oct 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • should have ADR: which attribute, tag, class we allowed. Sequence of this.....

guimard
guimard reviewed Oct 24, 2024
View reviewed changes
Comment thread core/test/utils/standardize_html_sanitizing_transformers_test.dart
@dab246
dab246 requested a review from guimard October 24, 2024 07:39
@hoangdat
hoangdat merged commit 3205e00 into master Oct 24, 2024
@hoangdat
hoangdat deleted the hotfix/sanitize_html branch September 19, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guimard guimard guimard approved these changes
@hoangdat hoangdat hoangdat approved these changes
@chibenwa chibenwa chibenwa approved these changes
@tddang-linagora tddang-linagora tddang-linagora approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dab246 @hoangdat @guimard @chibenwa @tddang-linagora