fix(search): find whole-word matches past the per-file substring cap - #168
Merged
Merged
Conversation
`--max-count` caps ripgrep's unfiltered hits, but whole-token filtering runs app-side, so a file whose first 50 hits are all substring-only loses every real match below that point and reports no truncation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keyword search with
whole_wordcould return nothing while a real match sat inthe file.
--max-countcaps ripgrep's unfiltered hits, but whole-token filteringruns app-side, so a file whose first 50 hits are all substring-only loses every
real match below that point and still reports no truncation.
What changed
--max-countonly on the substring path, where the whole-token filter isa no-op.
whole_wordis set, likesearchDerivedMarkdownalready does. Non-whole-word searches are unchanged.Validation
pnpm typecheckTwo new cases in
server/keyword-search.test.ts, red before and green after.UI and visual baselines
Documentation
design-docs/andcode-review/contract, when this changes documented behavior or invariants.