fix(loader): propagate plugin asset version digest to scoped stylesheet (closes #23 #24)#26
Merged
Merged
Conversation
|
|
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The host loader (
app-ui/.../plugins/loader.js) imports the plugin JS bundle via/main/<id>/vue/index.js?v=<digest>, where the MD5 digest rotates on every plugin upgrade (long-cached for 1 year, immutable). However, the CSS injection insideui/src/index.jsdid:Relative URL resolution drops the base query string, so the
<link>pointed atindex.csswithout the?v=cache buster. As a consequence, after any plugin upgrade the freshly-loaded JS bundle (newdata-v-*scope id) was paired with a stale, long-cachedindex.css(previousdata-v-*ids). Every scoped style of the SFCs in this plugin silently stopped matching, producing apparently random layout regressions with zero JS errors.Fix
Carry over the
?v=<digest>query fromimport.meta.urlto the CSS URL so the stylesheet is busted in lockstep with the JS bundle. Bonus: the CSS now benefits from the same 1-year immutable cache as the JS in production.Closes
Both were manifestations of the same root cause: scoped CSS classes silently dropped after each plugin upgrade.
Verified