feat(ui): add entity icons to dialog titles#16
Merged
Conversation
Prepend each dialog title with an icon representing the entity it concerns (projects, system users/roles/nodes/config, plugins, API tokens), matching the convention introduced in the host and plugin-id. Ref ligoj/plugin-id#51
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Part of generalizing dialog title icons across the application (ligoj/plugin-id#51). This repo's admin/system dialogs all used plain
v-dialogtitles with no icon.Change
Prepend a leading
v-iconrepresenting the entity to every dialog title (17 titles across 8 views):Section cards that already had icons are left untouched.
Test plan
Ref ligoj/plugin-id#51