Skip to content

Add configurable node color#911

Open
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:color
Open

Add configurable node color#911
benthecarman wants to merge 1 commit into
lightningdevkit:mainfrom
benthecarman:color

Conversation

@benthecarman
Copy link
Copy Markdown
Contributor

@benthecarman benthecarman commented May 20, 2026

Feature request from anon

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented May 20, 2026

I've assigned @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@ldk-reviews-bot ldk-reviews-bot requested a review from tnull May 20, 2026 03:47
Copy link
Copy Markdown
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide one example of where the color is actually used in 2026?

@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Jun 2, 2026

@benthecarman Any update on rationale for this, or can this be closed?

@benthecarman
Copy link
Copy Markdown
Contributor Author

I mean, it's something people want to set. For actual usage I'm not sure.

@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Jun 2, 2026

I mean, it's something people want to set. For actual usage I'm not sure.

Are there even any explorers left that show the rgb field in any way? Actually curious what use cases there still are? Is it just (ab)used to encode some aux data?

@benthecarman
Copy link
Copy Markdown
Contributor Author

@tnull
Copy link
Copy Markdown
Collaborator

tnull commented Jun 2, 2026

It's showed on mempool

https://mempool.space/lightning/node/02f7467f4de732f3b3cffc8d5e007aecdf6e58878edb6e46a8e80164421c1b90aa

Lol, I mean they mostly print the hex?

@randomlogin
Copy link
Copy Markdown
Contributor

It is wrong on mempool.space, it doesn't really shown as a color on a graph.
Though 1ml does show the colors: https://1ml.com/visual/network

But it is a part of a node announcement, so it seems a user should be able to configure it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants