This repository was archived by the owner on Sep 12, 2023. It is now read-only.
Add pods assignment to nodes#501
Open
placydo wants to merge 1 commit into
Open
Conversation
placydo
requested review from
a team and
marcospereira
and removed request for
a team
Collaborator
|
Hi @placydo, Thank you for your contribution! We really value the time you've taken to put this together. Before we proceed with reviewing this pull request, please sign the Lightbend Contributors License Agreement: |
|
Hey @placydo, thanks for taking the time to send this. I've changed the CircleCI configuration so that it will build this PR. That is why I'm closing/re-opening. |
Author
|
Do You need any additional input from my side? |
marcospereira
left a comment
marcospereira
left a comment
There was a problem hiding this comment.
An "empty" comment so that this will not be part of my "review requests" list.
Sorry for the noise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a way to assign pods to specific nodes. Also having a mechanism to avoid "noisy neighbor" on cluster is a nice thing to have.