build(mas): universal (x86_64 + arm64) App Store package#34
Merged
Conversation
The Mac App Store build was arm64-only, so it wouldn't run natively on Intel Macs (which App Store review may use). Make it universal: - electron-builder: mas target -> universal; add an x64ArchFiles rule so @electron/universal keeps onnxruntime's per-arch dylibs as-is instead of failing on the identical single-arch files. - scripts/build-universal-ffmpeg.mjs: fatten ffmpeg-static (ships a single host-arch binary) into a universal binary before the build. Idempotent, macOS-only. - electron:build:mas: run the ffmpeg step and pass --universal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Mac App Store build was arm64-only, so it wouldn't run natively on Intel Macs (which App Store review may use). This makes the MAS build universal.
Changes
mastarget →universal; addx64ArchFilesrule so@electron/universalkeeps onnxruntime's per-arch dylibs as-is (they load by arch at runtime) instead of erroring on identical single-arch files.ffmpeg-staticships a single host-arch binary; this fattens it into a universal binary before the build. Idempotent, macOS-only.electron:build:masruns the ffmpeg step and passes--universal.Verification
npm run electron:build:masproducesOut Loud-2.1.0-universal.pkg, verified universal (x86_64 + arm64) across app/framework/helpers/ffmpeg/onnxruntime, signed with Apple Distribution + provisioning profile, App Sandbox on.verify:maspasses.🤖 Generated with Claude Code