Package AppImages for Linux - #479
Closed
ravener wants to merge 7 commits into
Closed
Conversation
JakobDev
reviewed
Aug 28, 2023
There was a problem hiding this comment.
Just wait until the other PR is merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #415 by introducing AppImages.
This is a rough draft and meant to be a proof of concept, I've implemented it in the ci.yml for the purpose of easier testing instead of needing to trigger a release, but this needs to be moved to the release workflow when ready.
I've created this draft PR to get feedback if anything needs to be done differently, and additional cleanups that may be needed, other than that I can start copying it over to the release workflow and finalize the PR.
So a quick rundown of what is happening for the devs who are unfamiliar with AppImages:
.desktopfile.assets/app_icon.pnghope that is fine. the .desktop can be extended further if anything needs to be added, like a comment (program description basically).desktopfile for example./usr/libin the appdir did not work, so I chose to stuff it all in thebinso they are relative to the binary, this should be fine as I've seen other appimages stuff everything in there as well.To test this you can download the artifact from the latest commit in my fork unzip the artifact and
chmod +x liftoff.AppImageand finally./liftoff.AppImageTODO
Like I said so far I'm opening this as a draft PR to get some feedback, once I get the OK, I will squash my commits and any other cleanups suggested.