Skip to content

Minor Code refinement for performance #6

Open
dxyzx0 wants to merge 4 commits into
lifanchen-simm:masterfrom
dxyzx0:master
Open

Minor Code refinement for performance #6
dxyzx0 wants to merge 4 commits into
lifanchen-simm:masterfrom
dxyzx0:master

Conversation

@dxyzx0

@dxyzx0 dxyzx0 commented Oct 22, 2020

Copy link
Copy Markdown

In model.py

  1. These two for-loops in the model.py lowers the speed of training and testing, since it doesn't utilize broadcasting of matrix operation in torch.
    In main.py and mol_featurizer.py
  2. I trained my model on a larger dataset with protein length up to 2000 and 70w interactions. We should use joblib to load and dump large files.

Further Refinement:
I like this model very much. I use this model for production. Hence, there's my refinement of the code https://github.com/DingXiangYuanZhiXing/transformerCPI_DTA

Remove some redundant for-loop with pytorch build-in functionality.
joblib is more robust for large dataset
joblib is more robust for large dataset
@comeonzyx

Copy link
Copy Markdown

Hello,i would like to ask that do you have "dataset/celegans_uniprot.csv"?

@shaonvpiaoyaodesilian

Copy link
Copy Markdown

The bert.pkl file at this address is damaged. https://github.com/myzhengSIMM/transformerCPI2.0/releases. Can you upload a new one? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants