chore: add HEALTHCHECK to service Dockerfiles and smoke test in CI - #3429
Draft
ascariandrea wants to merge 1 commit into
Draft
chore: add HEALTHCHECK to service Dockerfiles and smoke test in CI#3429ascariandrea wants to merge 1 commit into
ascariandrea wants to merge 1 commit into
Conversation
Add HEALTHCHECK instructions to api, agent, web, and admin production stages so Docker/Kubernetes can probe container health at runtime. Also load built images into the local daemon during CI and run a quick smoke test (node --version) to verify the image is functional before pushing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ascariandrea-zeroclaw
left a comment
ascariandrea-zeroclaw
left a comment
There was a problem hiding this comment.
Findings:
- agent.Dockerfile line 40: HEALTHCHECK uses
curlwhile api/web/admin usewget. The agent production base (liexp-base:24-latest) may not include curl — verify or unify towget. - release-please.yml line 168: Smoke test runs for all services (including worker/ai-bot) but only checks
node --version, which doesn't verify app functionality beyond the runtime being present. - All Dockerfiles: HEALTHCHECK defaults embed hardcoded ports (4010/3003/80/3001). If
SERVER_PORT/VIRTUAL_PORTis set differently at runtime, the probe will target the wrong port.
ascariandrea-zeroclaw
left a comment
ascariandrea-zeroclaw
left a comment
There was a problem hiding this comment.
Good addition: adds HEALTHCHECK directives to all service Dockerfiles (admin, agent, api, web) using appropriate tools (wget/curl) and endpoints, plus a smoke test in CI that verifies node runtime works inside built images. The docker-build-push action now supports a load parameter for local image loading. No correctness bugs or security issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add HEALTHCHECK instructions to api, agent, web, and admin production stages so Docker/Kubernetes can probe container health at runtime. Also load built images into the local daemon during CI and run a quick smoke test (node --version) to verify the image is functional before pushing.