fix(api): create space bucket with correct policies - #3056
Draft
ascariandrea wants to merge 3 commits into
Draft
Conversation
ascariandrea
force-pushed
the
fix/api-bootstrap-bucket
branch
from
May 17, 2026 16:46
c79ae91 to
e12417d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Programmatic MinIO bucket creation at API startup, ensuring the bucket exists and is properly configured regardless of deployment environment.
Changes
checkBucketOrCreate.bootstrap.ts— New bootstrap step that checks ifSPACE_BUCKETexists, creates it if missing, with race-condition handling for concurrent pod startupsspace.provider.ts— AddedgetBucketandputBucketPolicymethods to the S3 provider interfacelocal-space.provider.ts— Stub implementations for testing.husky/pre-push— Fixed hook to build all packages first (was skipping@liexp/backenddue toprivate: true)Architecture
ACL: "public-read"in the upload flowCommits
fix(api): create space bucket with correct policies— Initial implementationfix(api): use object ACL for public-read instead of bucket policy— Bucket stays private, public-read per-objectfix(workspace): build all packages before pre-push filter— Fix pre-push hook