Skip to content

A bit more about TESFile#46

Open
Meridiano wants to merge 3 commits into
libxse:mainfrom
Meridiano:patch-1
Open

A bit more about TESFile#46
Meridiano wants to merge 3 commits into
libxse:mainfrom
Meridiano:patch-1

Conversation

@Meridiano

Copy link
Copy Markdown
Contributor

Move TESFileFlags and TESFileIndex into TESFile scope.
Make fileFlags member REX::TEnumSet.
Add TESFileText for author and description members.

_size is c-string size as returned by strlen, _bufferSize is always _size+1 (ie with \0)
@qudix

qudix commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

actually, it might be better to keep TESFileFlags and TESFileIndex in the RE scope, otherwise refering to them would look like TESFile::TESFileFlags

@Meridiano

Meridiano commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

actually, it might be better to keep TESFileFlags and TESFileIndex in the RE scope, otherwise refering to them would look like TESFile::TESFileFlags

The idea was taken from BGSEquipSlot::Flag and other similar cases already present in CLib. I can move TESFileFlags and TESFileIndex back to RE, or I can rename them to Flags (so, TESFile::Flags) and TypedIndex (because just Index is too vague, there's already compileIndex member) (so, TESFile::TypedIndex).

What is more preferred?

@qudix

qudix commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

I like the first more, but the second is fine too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants