A bit more about TESFile#46
Open
Meridiano wants to merge 3 commits into
Open
Conversation
_size is c-string size as returned by strlen, _bufferSize is always _size+1 (ie with \0)
Contributor
|
actually, it might be better to keep TESFileFlags and TESFileIndex in the RE scope, otherwise refering to them would look like |
Contributor
Author
The idea was taken from BGSEquipSlot::Flag and other similar cases already present in CLib. I can move TESFileFlags and TESFileIndex back to RE, or I can rename them to Flags (so, TESFile::Flags) and TypedIndex (because just Index is too vague, there's already compileIndex member) (so, TESFile::TypedIndex). What is more preferred? |
Contributor
|
I like the first more, but the second is fine too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move TESFileFlags and TESFileIndex into TESFile scope.
Make fileFlags member REX::TEnumSet.
Add TESFileText for author and description members.