Loadso's Unload returns bool to indicate success/failure#15918
Open
CowKeyMan wants to merge 1 commit into
Open
Loadso's Unload returns bool to indicate success/failure#15918CowKeyMan wants to merge 1 commit into
CowKeyMan wants to merge 1 commit into
Conversation
Collaborator
|
I'll throw this in the 4.x milestone, since changing a function's return value changes the ABI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging loading dynamic libraries, and in this case, while debugging unloading them, it would be good to have the necessary debug tools. This PR allows the user to rule out any possibility that it is loadso's unloading that is failing, but rather something else in the user's code. Or if it actually is failing, then the user will know of the failure and also get an appropriate error message from the OS.
Existing Issue(s)
No existing issues