Repository navigation
gl: report views from init, not from the first frame - #19953
Merged
Merged
Conversation
gl2 published whether it can draw views only from gl2_frame(), so until its first frame it reported none. At content start and after each video driver reinit, a core asking for the views status on its first retro_run() was told views are neither presented nor stereo, and that frame was not laid out as views: one frame of the core's own layout, or of its packed frame shown whole. gl2 now publishes it at init, as vulkan does.
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
What it does
gl2_frame(), so a new gl2 reported no views until it had drawn a frame.RETRO_ENVIRONMENT_GET_VIDEO_VIEWS_STATUSon its firstretro_run()was told views are neither presented nor stereo. That frame was also not laid out as views. On gl the user saw one frame of the core's own layout, or of its packed frame shown whole. vulkan was not affected.Tested
threaded_videolane on the gl driver: it reads the views flag right after a reinit and again after two frames. On master it fails withviews 0 from init, 1 after a frame. With the fix it passes, on Linux (llvmpipe under Xvfb) and in a mingw-w64 build under Wine.C89_BUILD=1ongl2.o.tools/ci_local.pyin an Ubuntu 24.04 image, all pass: gl-harness (every api and sanitizer entry), the vulkan validation, ASan, TSan and OpenXR harnesses, menu-harness, pace-shadow, tsan-harness, vulkan-resize, egl-hw-core, overlay-on-screen, samples-gfx, slang-last-pass-target, windows-wine-menu and compile-matrix.Related Issues
[Any issues this pull request may be addressing]
Related Pull Requests
[Any other PRs from related repositories that might be needed for this pull request to work]
Reviewers
[If possible @mention all the people that should review your pull request]