Skip to content

MCP: Options instead of toggles, correct error handling #19731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LibretroAdmin merged 3 commits into from
Oct 10, 2026
Merged

MCP: Options instead of toggles, correct error handling #19731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8348f12
tests: cover MCP option state and speed changes
codex Oct 10, 2026
3dbd6da
mcp: SET_OPTION/GET_OPTION, real errors
RobLoach Oct 7, 2026
dbdd770
mcp: apply option changes to runtime state
codex Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .github/workflows/Linux-network-clients.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,17 @@ jobs:
make -C samples/network/mcp_server check
make -C samples/network/mcp_server clean

- name: Command options and speed setters
shell: bash
working-directory: ${{ github.workspace }}
run: |
set -eu
make -C samples/network/command_options clean
make -C samples/network/command_options SANITIZER=address,undefined
ASAN_OPTIONS=detect_leaks=1 UBSAN_OPTIONS=halt_on_error=1 \
make -C samples/network/command_options check
make -C samples/network/command_options clean


- name: Windows builds under Wine
shell: bash
Expand Down Expand Up @@ -162,6 +173,9 @@ jobs:
make -C samples/network/mcp_server compiler=x86_64-w64-mingw32-gcc
(cd samples/network/mcp_server && wine ./mcp_server_test.exe)
make -C samples/network/mcp_server clean
make -C samples/network/command_options compiler=x86_64-w64-mingw32-gcc
(cd samples/network/command_options && wine ./command_options_test.exe)
make -C samples/network/command_options clean
export CC=x86_64-w64-mingw32-gcc RUNNER=wine EXE=.exe
make -C samples/network/tls_retro clean
samples/network/tls_retro/local_server_test.sh
Expand Down
Loading
Loading