treewide: reword lime_release and extend the usage of libremesh.mk - #1274
Open
a-gave wants to merge 1 commit into
Open
treewide: reword lime_release and extend the usage of libremesh.mk#1274a-gave wants to merge 1 commit into
a-gave wants to merge 1 commit into
Conversation
a-gave
force-pushed
the
fix/libremesh_mk
branch
5 times, most recently
from
August 27, 2026 11:07
ca6817d to
f9f5a3d
Compare
a-gave
marked this pull request as ready for review
August 27, 2026 12:22
a-gave
force-pushed
the
fix/libremesh_mk
branch
from
September 2, 2026 15:45
f9f5a3d to
d02a572
Compare
libremesh.mk: extend the usage to all packages without a pkg_source_url lime-debug: use libremesh.mk lime-docs: fix banner not displayed lime-system: use libremesh.mk to remove comments from the built package lime-system: drop compatibility script for v2020.4 migrate-wifi-bands lime-system: reword /etc/lime_release 'development' to 'nightly' which is shorter and emphasizes the fact that the code is usable but it is not a fixed/stable release. While 'development' is more vague. lime-system: reword lime_description and add it to /etc/os-release from: LiMe master development (master rev. 0b6b5c5 20260810_1130) to: LibreMesh 25.12.5 r26.222.40775~0b6b5c5 nightly This text then displayed: - in the lime-app status page - via ssh after the banner via the profile.d/10-lime-banner.sh - via cli running `ubus call system board` shared-state-async: symlink script and add the missing dependency on shared-state Fixes: libremesh#766
a-gave
force-pushed
the
fix/libremesh_mk
branch
from
September 2, 2026 15:54
d02a572 to
783a7bf
Compare
Contributor
Author
|
Edited the description to mention the removal of comments from the package lime-system using libremesh.mk |
a-gave
had a problem deploying
to
physical-lab
September 2, 2026 16:09 — with 
GitHub Actions
Failure
GitHub Actions
Failure
ilario
reviewed
Sep 5, 2026
|
|
||
| LIME_DESCRIPTION="$LIME_ID $DISTRIB_RELEASE $LIME_VERSION_CODE" | ||
|
|
||
| sed -i -e "s,^\(OPENWRT_RELEASE=\).*$/\1$LIME_DESCRIPTION/g" \ |
Member
There was a problem hiding this comment.
here it seems that the expression uses a "," as a field separator, but then changes to "/", no?
ilario
reviewed
Sep 5, 2026
| $(1)/etc/lime_release \ | ||
| $(1)/etc/profile.d/10-lime-banner.sh | ||
| $(INSTALL_DIR) $(1)/etc/lime-assets/community/ | ||
| $(INSTALL_DIR) $(1)/etc/lime-assets/node/ |
Member
There was a problem hiding this comment.
Aren't the new .placeholder files you introduced in this pull request enough for ensuring that these folders are created?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which is shorter and emphasizes the fact that the code is usable but it is not a fixed/stable release. While 'development' is more vague.
from: LiMe master development (master rev. 0b6b5c5 20260810_1130)
to: LibreMesh 25.12.5 r26.222.40775~0b6b5c5 nightly
This text then displayed:
ubus call system boardFixes: #766