Skip to content

Fix Smart HTTP push framing #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genedna merged 1 commit into from
Jul 22, 2026
Merged

Fix Smart HTTP push framing #442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/internal/protocol/https_client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::{io::Error as IoError, ops::Deref, sync::Mutex, time::Duration};

use futures_util::{StreamExt, TryStreamExt};
use git_internal::errors::GitError;
use reqwest::{Body, RequestBuilder, Response, StatusCode, header::CONTENT_TYPE};
use reqwest::{RequestBuilder, Response, StatusCode, header::CONTENT_TYPE};
use url::Url;

use super::{
Expand Down Expand Up @@ -464,10 +464,7 @@ impl HttpsClient {
Ok(result)
}

pub async fn send_pack<T: Into<Body> + Clone>(
&self,
data: T,
) -> Result<Response, reqwest::Error> {
pub async fn send_pack(&self, data: bytes::Bytes) -> Result<Response, reqwest::Error> {
// INVARIANT: "git-receive-pack" is a valid relative URL onto self.url.
let receive_pack_url = self
.url
Expand All @@ -477,6 +474,12 @@ impl HttpsClient {
self.client
.post(receive_pack_url.clone())
.header(CONTENT_TYPE, "application/x-git-receive-pack-request")
.header(
reqwest::header::ACCEPT,
"application/x-git-receive-pack-result",
)
.header(reqwest::header::USER_AGENT, "git/2.43.0 libra")
.header(reqwest::header::CONTENT_LENGTH, data.len())
.body(data.clone())
})
.await
Expand Down
Loading