Skip to content

fix(rendezvous): cap TTL from discovery responses #6619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jxs wants to merge 3 commits into
base: master
Choose a base branch
from
+10 −4
Open

fix(rendezvous): cap TTL from discovery responses #6619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
691dc24
fix(rendezvous): cap TTL from discovery responses
jxs Sep 14, 2026
79394fe
Merge branch 'master' into fix/rendezvous-cap
jxs Sep 14, 2026
c5a3eed
update TTL after discussion with elena
jxs Sep 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ libp2p-plaintext = { version = "0.44.0", path = "transports/plaintext" }
libp2p-pnet = { version = "0.27.0", path = "transports/pnet" }
libp2p-quic = { version = "0.14.0", path = "transports/quic" }
libp2p-relay = { version = "0.22.0", path = "protocols/relay" }
libp2p-rendezvous = { version = "0.18.0", path = "protocols/rendezvous" }
libp2p-rendezvous = { version = "0.18.1", path = "protocols/rendezvous" }
libp2p-request-response = { version = "0.30.0", path = "protocols/request-response" }
libp2p-server = { version = "0.13.0", path = "misc/server" }
libp2p-stream = { version = "0.5.0-alpha", path = "protocols/stream" }
Expand Down
5 changes: 5 additions & 0 deletions protocols/rendezvous/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 0.18.1

- Cap TTL from discovery responses.
See [PR #6619](https://github.com/libp2p/rust-libp2p/pull/6619)

## 0.18.0

- Expose `PROTOCOL_NAME` constant for the protocol ID.
Expand Down
2 changes: 1 addition & 1 deletion protocols/rendezvous/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name = "libp2p-rendezvous"
edition.workspace = true
rust-version = { workspace = true }
description = "Rendezvous protocol for libp2p"
version = "0.18.0"
version = "0.18.1"
authors = ["The COMIT guys <hello@comit.network>"]
license = "MIT"
repository = "https://github.com/libp2p/rust-libp2p"
Expand Down
3 changes: 2 additions & 1 deletion protocols/rendezvous/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,8 @@ impl Behaviour {
let peer_id = registration.record.peer_id();
let addresses = registration.record.addresses();
let namespace = registration.namespace.clone();
let ttl = registration.ttl;
// Max TTL allowed, 1 year to avoid overflows.
let ttl = registration.ttl.min(31_556_952);

// Emit events for all newly discovered addresses.
let new_addr_events = addresses
Expand Down
Loading