This repository was archived by the owner on May 26, 2022. It is now read-only.
Add the ability to map ports with external port specified - #8
Closed
cannium wants to merge 2 commits into
Closed
Conversation
Member
|
Blocked on discussion here: libp2p/go-libp2p#411 |
Stebalien
added
the
status/blocked
Member
|
Status: We had to revert stable port mapping, unfortunately, as routers suck: libp2p/go-nat#8. Basically, some routers (including my nice tp-link one) won't bother checking for conflicts between UPnP mappings and explicit port forwarding. |
Stebalien
removed
the
status/blocked
Member
|
@Stebalien I guess that was a non-trivial debugging trip. Curious to learn how you got to the end of it! |
Member
|
I can't remember the details, just that my node went from dialable to undialable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the dependency from
github.com/fd/go-natto my forked version. I think it's better to forkgo-natunderlibp2p