Fix converting octal integers in erfa_generator#281
Merged
Conversation
The C source code for ERFA tests contains the integer literals `06` and `01`. Most people (apparently including the author of 1effd5f (Create tests for each function based on the built-in C tests.)) might think that such leading zeros can simply be dropped without changing what the literal represents, but in C the leading zero actually means the integer is written in octal. This has not caused problems in practice because dropping the leading zero happens to work with the values `erfa_generator` encounters.
avalentino
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C source code for ERFA tests contains the integer literals
06and01. Most people (apparently including the author of 1effd5f) might think that such leading zeros can simply be dropped without changing what the literal represents, but in C the leading zero actually means the integer is written in octal (see also PEP 3127 – Integer Literal Support and Syntax). This has not caused problems in practice because dropping the leading zero happens to work with the valueserfa_generatorencounters.