Skip to content

improvement: add icon with yellow stroke - #2199

Open
WofWca wants to merge 3 commits into
liberapay:masterfrom
WofWca:icon-white-stroke
Open

improvement: add icon with yellow stroke#2199
WofWca wants to merge 3 commits into
liberapay:masterfrom
WofWca:icon-white-stroke

Conversation

@WofWca

@WofWca WofWca commented Dec 17, 2022

Copy link
Copy Markdown
Contributor

It's hard to see the current one on dark background, so.

Before After
old on white new on white
old on black new on black

Closer look (yes, the stroke overflows the canvas):

image

TODO:

  • Replace the favicon.
  • Generate PNGs.
  • Search for occurrences of "icon-v2_black" in the codebase and replace where appropriate.
  • Consider white stroke instead of yellow.

I'll do these if you like the change.

@trebmuh

trebmuh commented Dec 17, 2022

Copy link
Copy Markdown
Member

nice looking

@Changaco

Copy link
Copy Markdown
Member

It doesn't look quite right to me. Maybe if the outline was thinner or had an alpha gradient?

Is this change only for the favicon, or do you have another reason?

@WofWca

WofWca commented Dec 20, 2022

Copy link
Copy Markdown
Contributor Author

For the favicon in the first place. Maybe there are other places it can be useful in.

@WofWca

WofWca commented Dec 20, 2022

Copy link
Copy Markdown
Contributor Author

Maybe if the outline was thinner or had an alpha gradient?

I have picked width that looked the best to me at 16px width (the ones in the table). You can play around with it in the dev tools as well.
For the gradient - currently I'm not sure how to achieve it.

@WofWca

WofWca commented Dec 25, 2022

Copy link
Copy Markdown
Contributor Author

Hey, I also just learned that you can set different favicons depending on color scheme, with the media attribute

@Changaco

Copy link
Copy Markdown
Member

@WofWca I assume you're talking about prefers-color-scheme. It doesn't seem to work on favicons in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants