improvement: add icon with yellow stroke - #2199
Open
WofWca wants to merge 3 commits into
Open
Conversation
Member
|
nice looking |
Which is visible on both dark and light backgrounds
WofWca
force-pushed
the
icon-white-stroke
branch
from
December 18, 2022 08:48
872470b to
8246266
Compare
Member
|
It doesn't look quite right to me. Maybe if the outline was thinner or had an alpha gradient? Is this change only for the favicon, or do you have another reason? |
Contributor
Author
|
For the favicon in the first place. Maybe there are other places it can be useful in. |
Contributor
Author
I have picked width that looked the best to me at 16px width (the ones in the table). You can play around with it in the dev tools as well. |
Contributor
Author
|
Hey, I also just learned that you can set different favicons depending on color scheme, with the |
Member
|
@WofWca I assume you're talking about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's hard to see the current one on dark background, so.
Closer look (yes, the stroke overflows the canvas):
TODO:
I'll do these if you like the change.