Upgrade to libdns v1.1.1 and adjust tests - #5
Conversation
- Remove manual ID assignment (handled automatically by getRecordId) - Simplify tests to work with Record interface - Tests now compile and are ready for libdns v1.1.1
jhf
changed the title
|
@anderspitman Not sure if you are the correct person to bother with this? There's a few other bugs too but I'll make a review for those in a moment. Sorry to bother you, and much thanks in advance :) |
| } | ||
|
|
||
| return errors.WithStack(er) | ||
| return err |
There was a problem hiding this comment.
The if err != nil { check guarantees that err will always be nil, so this ends up returning nil which causes a few issues.
| return err | |
| return er |
| return 0, err | ||
| } | ||
|
|
||
| name := libdns.AbsoluteName(record.RR().Name, zone) |
There was a problem hiding this comment.
Needs add a . appended.
The name.com API always returns FQDNs with a trailing ., but libdns.AbsoluteName never does.
| name := libdns.AbsoluteName(record.RR().Name, zone) | |
| name := libdns.AbsoluteName(record.RR().Name, zone) + "." |
|
@toast-riot this is the first I'm seeing this PR. Looks like the original author deleted their GH account. I only made one small contribution. Not sure what the policy is here. @mholt? |
4 participants
Summary
Upgrades libdns/namedotcom to work with libdns v1.1.1 (addresses #3)
Changes
Credits
Based on the work by @ykarachev in his upgrade PR. Fixed test suite for compatibility with Record interface.
Testing
Resolves #3
Enables: caddy-dns/namedotcom#5