Repository navigation
map: Add corresponding function for parsing memlock as u64 - #1467
Merged
Merged
Conversation
Currently, the memlock field of MapFdInfo is parsed as an u32 value. Given that the field is marked as an u64 value, add a function for parsing an u64 value. This can be helpful to parse memlock values higher than u32::MAX and not returning an error in this case. Signed-off-by: Andra Paraschiv <andra.paraschiv@gcore.com>
d-e-s-o
approved these changes
Oct 9, 2026
d-e-s-o
left a comment
d-e-s-o
left a comment
Collaborator
There was a problem hiding this comment.
Seems fine to me, thanks.
Contributor
Author
Thank you for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the memlock field of MapFdInfo is parsed as an u32 value. Given that the field is marked as an u64 value, add a function for parsing an u64 value. This can be helpful to parse memlock values higher than u32::MAX and not returning an error in this case.
Thank you for considering a contribution!
In order to streamline review experience for contributors and reviewers, please
be sure to read and follow the Contributor's Guide. It
lays out basic best practices, which, if followed will reduce unnecessary back
and forth and, ultimately, minimize the time it takes to get your change into
the library.