Repository navigation
Fix the three bugs and six design gaps found in review - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A review of the package against agent-shell 0.75.2, Codex
/sideat 2df67054, Claude Code's/btw, and ChatGPT's branch feature. Three bugs and six design gaps, each decided before it was fixed. DESIGN.md section 5 records the reasoning.Bugs
agent-shell-insertrefuses while a turn runs and the subscriber wrapper swallowed the error. The stub never refused, so no test caught it.agent-shell-side-links-removehad no callers.Decisions
agent-shell-prefer-viewport-interactionthat is the parent's compose buffer, opened in edit mode so a busy parent still takes it. Otherwise the shell prompt, at once when idle or as soon as the turn ends. The side conversation stays open and marked pending until then.systemPrompt.appendis kept ahead of the side text, as Codex keeps its developer instructions. No boundary-version bump: the side text is unchanged.agent-shell-side-on-dismissdefaults todelete, matching Codex's ephemeral thread.Without a decision
Preconditions run before the question is read. The parent-status echo needs the side buffer on screen. The dismiss prompt no longer names a
/sidecommand Emacs does not have. Three checkdoc nits. The test stub'sagent-shell-insertnow refuses a busy target like the real one, which is what had hidden the first bug.Verification
make checkpasses 92 tests, up from 78. Byte-compile is clean against the stubs and against the real agent-shell 0.75.2 stack. checkdoc is clean.Not verified live. The viewport compose path and the wait-for-idle handback are covered by stub tests that mirror upstream's argument shapes and event ordering, but no real agent has run them.