Skip to content

identified entity 0x1B as shockwave - #9

Merged
lhsazevedo merged 1 commit into
lhsazevedo:mainfrom
rossipo:fix/rename-shockwave
Jun 5, 2026
Merged

identified entity 0x1B as shockwave#9
lhsazevedo merged 1 commit into
lhsazevedo:mainfrom
rossipo:fix/rename-shockwave

Conversation

@rossipo

@rossipo rossipo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Identified shockwave entity according to Issue #3

@lhsazevedo lhsazevedo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lhsazevedo
lhsazevedo merged commit 7720fae into lhsazevedo:main Jun 5, 2026
1 check passed
@lhsazevedo

Copy link
Copy Markdown
Owner

Thanks for the contribution! And welcome to the project.

As a small follow-up, I’d like to avoid keeping the raw 0x1B entity ID inline. When able, could you please open another PR adding the shockwave entity ID to src/constants/entity.asm, then updating the code that spawns the entity to use that constant?

Thanks!

@rossipo
rossipo deleted the fix/rename-shockwave branch June 5, 2026 20:35
@rossipo

rossipo commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for your great work!
Hope to contribute some more in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants