Feature/milestone 03 update sb - #64
Merged
Merged
Conversation
- Añade tests de value objects (Password, PhoneNumber, Email) y utilidades (DateTimeExtensions, PageRequest, PageResult) - Completa UserTest con changePassword, roles y validaciones - Activa CreateUserServiceTest (stub), GetUserUseCase, UpdateUserUseCase, UserMapper, PasswordEncoder y DuplicateEmailException - Añade ExampleRepositoryAdapterTest y ExampleEntityTest - Cubre HotelRoomJpaRepository con tests @DataJpaTest (spec, rooms) - Añade SentryControllerTest con mockkStatic(Sentry) - Corrige RoomEntity.id nullable y HotelRoomJpaRepository.save con flush/clear para que el cascade de habitaciones persista correctamente y el filtrado por Specification funcione - Corrige HotelJpaRepository para usar @EntityGraph override de findAll(spec, pageable) en lugar de @query ignorado - Cobertura: 64.5% -> 93% (supera el 85% requerido)
- Actualiza plugin org.springframework.boot de 4.0.8 a 4.1.1 (Spring Boot 4.1.1 publicado el 2026-08-20, 98 fixes sobre 4.1.0) - Elimina dependencias no estándar spring-boot-http-client y spring-boot-restclient con versión explícita 4.0.8 (no existen como artefactos oficiales; no se usan en src/main, starter spring-boot-starter-restclient ya cubre el caso) - Verificado: ./gradlew clean build pasa (tests 93% cobertura, ktlint y detekt verdes)
Owner
Author
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descripción
Actualizar Spring Boot 4.1.1
Configurar mcp, lsp para el stack del proyecto
Configurar el proyecto con VSCode
Eliminar dependencias sin uso
Se aumenta la cobertura de pruebas para la migracion de SB
Tipo de cambio
Enfoque TDD
Checklist de calidad
./gradlew test)./gradlew ktlintCheckodetekt)Documentación
Cómo probar
git checkout feature/milestone-03-update-sb<slug>./gradlew clean bootRun./gradlew test