Clean up the nav and warm the palette - #8
Merged
Merged
Conversation
The name had a full stop after it, which read as a typo rather than a mark. The two links were bare words. They carry their own logos now, as inline SVG that takes the surrounding text colour, so each theme gets them without a second asset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name had a full stop after it, which read as a typo. The two links were bare words and now carry their own logos as inline SVG, inheriting the surrounding text colour so every theme gets them for free.
Brand marks rather than emoji: there is no GitHub or LinkedIn emoji, and the nearest generic ones read as clip art.
Verified in headless Chromium: brand reads
Laksh Goyal, two marks present, no console errors, no horizontal overflow.