Repository navigation
Broaden TEXT token pattern to accept all non-special characters - #11
Merged
Merged
Conversation
Add tests that verify the lexer tokenizes and the expander handles text containing accented and special characters like café-latte. These tests currently fail because the TEXT token pattern only matches word characters and whitespace. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Change the TEXT regex from /^(\w|\s)+/ to /^[^()?|+\\]+/ so that any character that isn't a special token character is valid text. This allows accented characters, hyphens, and other symbols. Remove the "should throw on unsupported characters" test since all non-special characters are now valid text. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/^(\w|\s)+/to/^[^()?|+\\]+/so any character that isn't a special token is valid textcafé-latte)Test plan
café-latteas a single TEXT tokencafé-latteto['café-latte']🤖 Generated with Claude Code