Adopt rstest 0.26.1#394
Conversation
Update the workspace and test-support `rstest` dependency to 0.26.1 and refresh the lockfile so the matching macro crate is used. Remove the obsolete BDD fixture `missing_docs` lint expectation because the generated fixture code no longer triggers it, and warnings-denied Clippy now rejects the stale expectation.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughBump Changesrstest upgrade and fixture lint cleanup
Poem
🚥 Pre-merge checks | ✅ 19 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (19 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9bc59a35bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Update the nested `test_support/Cargo.lock` so standalone builds from `test_support/` resolve `rstest` and `rstest_macros` to 0.26.1. This keeps locked `test_support` workflows aligned with the manifest bump and avoids requiring a local lockfile rewrite before building the crate.
Summary
This branch updates the workspace to use
rstest0.26.1 in both the main crate and the sharedtest_supportcrate, then refreshes both lockfiles so the matchingrstest_macrosrelease is used in workspace and standalonetest_support/builds. It also removes a stale BDD fixture lint expectation that the updated macro output no longer needs and that warnings-denied Clippy now rejects.Review walkthrough
test_support/builds resolverstestandrstest_macrosto 0.26.1.Validation
make check-fmt: passed.make lint: passed.make test: passed.cd test_support && cargo check --locked: passed.References