Skip to content

Adopt rstest 0.26.1#394

Merged
leynos merged 2 commits into
mainfrom
adopt-rstest-v0-26-1
Jun 29, 2026
Merged

Adopt rstest 0.26.1#394
leynos merged 2 commits into
mainfrom
adopt-rstest-v0-26-1

Conversation

@leynos

@leynos leynos commented Jun 26, 2026

Copy link
Copy Markdown
Owner

Summary

This branch updates the workspace to use rstest 0.26.1 in both the main crate and the shared test_support crate, then refreshes both lockfiles so the matching rstest_macros release is used in workspace and standalone test_support/ builds. It also removes a stale BDD fixture lint expectation that the updated macro output no longer needs and that warnings-denied Clippy now rejects.

Review walkthrough

Validation

  • make check-fmt: passed.
  • make lint: passed.
  • make test: passed.
  • cd test_support && cargo check --locked: passed.

References

Update the workspace and test-support `rstest` dependency to 0.26.1
and refresh the lockfile so the matching macro crate is used.

Remove the obsolete BDD fixture `missing_docs` lint expectation because
the generated fixture code no longer triggers it, and warnings-denied
Clippy now rejects the stale expectation.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

codescene-access[bot]

This comment was marked as outdated.

@leynos leynos marked this pull request as ready for review June 26, 2026 18:34
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Bump rstest to 0.26.1 in the root and test support manifests, and remove the BDD fixture module’s crate-level missing_docs expectation.

Changes

rstest upgrade and fixture lint cleanup

Layer / File(s) Summary
Dependency version updates
Cargo.toml, test_support/Cargo.toml
rstest is bumped from 0.18.0 to 0.26.1 in both manifests.
BDD fixture lint adjustment
tests/bdd/fixtures/mod.rs
Remove the crate-level #![expect(missing_docs)] attribute from the fixture module.

Poem

A tiny bump, a lint let go,
The test crates hum in steady flow.
Fixtures stand without the veil,
And version pins now tell the tale.
🧪

🚥 Pre-merge checks | ✅ 19 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Testing (Compile-Time / Ui) ⚠️ Warning No trybuild test covers the rstest version/lint-contract change; the only trybuild harness targets Kani cfgs, not this compile-time surface. Add a focused trybuild case for the rstest fixture/macro expansion or lint contract that changed, and assert the expected compile-time result.
✅ Passed checks (19 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: upgrading rstest to 0.26.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Testing (Overall) ✅ Passed PASS: this is a dependency/lint-only change; the existing BDD suite already exercises the touched fixtures and assertions, so no new behaviour is left untested.
User-Facing Documentation ✅ Passed Leave the users guide unchanged: this PR only updates test dependencies and internal BDD linting, with no user-facing behaviour change.
Developer Documentation ✅ Passed PASS: only rstest/lockfile bumps and a stale test lint removal; no internal API, architecture, or build-process change requiring guide or ADR updates.
Module-Level Documentation ✅ Passed PASS: tests/bdd/fixtures/mod.rs still begins with a clear module docstring describing the BDD fixture module and its rstest-bdd role.
Testing (Unit And Behavioural) ✅ Passed PASS: this PR is maintenance-only; the repo already has meaningful unit tests for env isolation and scenario-driven BDD coverage, and no behavioural surface changed.
Testing (Property / Proof) ✅ Passed Only a dependency bump and lint cleanup changed; no new invariant, ordering, or transition logic was introduced, so property proving is not warranted.
Unit Architecture ✅ Passed Only manifests, lockfile, and a test-only lint cleanup changed; no production query/command boundaries or hidden side-effects were introduced.
Domain Architecture ✅ Passed The patch only bumps dev/test dependencies and removes a BDD fixture lint expectation; no domain, adapter, or infrastructure production code changed.
Observability ✅ Passed The diff only bumps dev/test rstest versions and removes a stale test lint expectation; no runtime observability surface changed.
Security And Privacy ✅ Passed Only test dependency bumps and a lint expectation removal were changed; no secrets, auth, permissions, or data-exposure paths were introduced.
Performance And Resource Use ✅ Passed Accept: only dev-dependency bumps and a lint-only fixture edit; no hot-path, allocation, or I/O changes.
Concurrency And State ✅ Passed PASS: The PR only bumps rstest and removes a stale lint expectation; it introduces no new shared state, async work, locks, or ordering semantics.
Architectural Complexity And Maintainability ✅ Passed The PR only bumps rstest and removes an obsolete lint expectation; it adds no new layers, traits, registries, or orchestration, so complexity stays flat.
Rust Compiler Lint Integrity ✅ Passed Touched files only bump rstest and remove a stale missing_docs expect; no new broad suppressions or suspicious clones appear.
Description check ✅ Passed Describe the rstest upgrade, lockfile refresh, and stale lint expectation removal reflected in the changed files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch adopt-rstest-v0-26-1

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bc59a35bc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread test_support/Cargo.toml
Update the nested `test_support/Cargo.lock` so standalone builds from
`test_support/` resolve `rstest` and `rstest_macros` to 0.26.1.

This keeps locked `test_support` workflows aligned with the manifest bump
and avoids requiring a local lockfile rewrite before building the crate.
@leynos leynos marked this pull request as draft June 27, 2026 23:28
@leynos leynos marked this pull request as ready for review June 28, 2026 01:54

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@leynos leynos merged commit 4608359 into main Jun 29, 2026
26 checks passed
@leynos leynos deleted the adopt-rstest-v0-26-1 branch June 29, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant