Decouple runner process execution from Cli (#339)#371
Draft
leynos wants to merge 1 commit into
Draft
Conversation
The low-level subprocess adapter in `runner::process` accepted `&Cli` through command construction and its request structs, coupling it to the parser/config domain type and making reuse and testing harder. Introduce `NinjaProcessOptions` — the narrow execution type carrying only what the process layer needs (working directory, job count, and the stderr-suppression flag) — and translate from `Cli` once at the orchestration boundary via `runner::ninja_process_options`. The public `run_ninja`/`run_ninja_tool` entry points keep their `&Cli` signatures but now live in `runner::mod` as thin translating wrappers, so existing callers and tests are unchanged. `runner::process` no longer imports `Cli` at all; making the stderr flag a named policy type is tracked separately in #340.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Reviewer's GuideDecouples the runner subprocess layer from the Cli type by introducing a narrow NinjaProcessOptions struct and performing Cli-to-process translation at the runner orchestration boundary, keeping public runner APIs unchanged while updating internal request/command configuration plumbing. Sequence diagram for run_ninja decoupled call flowsequenceDiagram
participant Caller
participant runner as runner
participant process as process
participant cmd as Command
Caller->>runner: run_ninja(program, cli, build_file, targets)
runner->>runner: ninja_process_options(cli)
runner->>process: run_ninja(program, options, build_file, targets)
process->>cmd: configure_ninja_build_command(cmd, options, build_file, targets)
process->>process: run_command_and_stream(cmd, status_observer, options.suppress_stderr)
process-->>runner: io::Result
runner-->>Caller: io::Result
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
Gates Failed
(1 file with Code Duplication)
Our agent can fix these. Install it.
Gates Passed
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| mod.rs | 1 advisory rule | 9.39 → 9.10 | Suppress |
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
| //! Internal to `runner`; public API is defined in `runner.rs`. | ||
|
|
||
| use super::{BuildTargets, NINJA_PROGRAM}; | ||
| use crate::cli::Cli; |
There was a problem hiding this comment.
❌ Getting worse: Code Duplication
introduced similar code in: run_ninja_build_internal,run_ninja_tool_internal
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #339
The subprocess adapter in
src/runner/process/mod.rsaccepted&Cliinconfigure_ninja_base, both request structs, and the public entry points, coupling the process layer to the parser/config domain type.Changes
src/runner/process/mod.rs: newNinjaProcessOptions(working directory, job count, stderr suppression) — the narrow execution type the issue proposes.configure_ninja_*,NinjaBuildRequest, andNinjaToolRequestconsume it; the module no longer importsCli.src/runner/mod.rs:ninja_process_options(&Cli)performs the CLI-to-process translation at the orchestration boundary;run_ninja/run_ninja_toolkeep their public&Clisignatures as thin wrappers, so existing behaviour, callers, and tests are unchanged.Replacing the boolean stderr flag with an explicit policy type is #340, designed together with this change and stacked on it.
Validation
make check-fmt/make lint/make test— pass (37 suites; runner behaviour covered by existing tests, unchanged)🤖 Generated with Claude Code
Summary by Sourcery
Decouple the runner subprocess adapter from the CLI type by introducing a narrow Ninja process options struct and translating CLI state at the runner boundary.
Enhancements: