Skip to content

Refresh generated spelling exceptions - #85

Merged
leynos merged 1 commit into
mainfrom
refresh-generated-typos-config
Nov 3, 2026
Merged

leynos merged 1 commit into
mainfrom
refresh-generated-typos-config

Conversation

@leynos

@leynos leynos commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

Summary

This branch refreshes the generated spelling rules after the spelling gate
produced a Tokio local-flavour exception. The narrow pattern admits
flavor = "local" in #[tokio::main] annotations, while removing the
previous broad ignore keeps spelling checks active elsewhere.

Review walkthrough

  • The specific exception and remaining ignore rules appear in
    typos.toml.

Validation

  • make all: passed sequentially on the candidate containing this generated
    config and the stacked documentation changes.
  • make spelling: passed within make all.

References

Regenerate the shared exception set after the spelling gate refreshes its
rules. Permit the Tokio local flavour annotation specifically and remove
the broad `flavor = ` ignore so spelling checks remain active elsewhere.
@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • typos.toml is excluded by !typos.toml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: c60adecc-f073-4ab9-8c2c-92f4ea89f47a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refreshes the generated spelling configuration to allow Tokio’s local runtime flavor only in the relevant #[tokio::main] annotation, while removing the broad flavor exception and preserving spelling coverage elsewhere. Validation passed through make all, including make spelling.

File-Level Changes

Change Details Files
Replace the broad flavor = spelling ignore with targeted Tokio attribute patterns.
  • Add a generated regex covering flavor = "local" in #[tokio::main(...)], including flexible whitespace and attribute formatting.
  • Retain narrowly scoped matching for supported Tokio main/test attributes and argument orderings.
  • Remove the previous repository-wide flavor = ignore so spelling checks remain active elsewhere.
typos.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@leynos
leynos added this pull request to stack #87 November 3, 2026 11:49
@leynos
leynos marked this pull request as ready for review November 3, 2026 18:26
@sourcery-ai

sourcery-ai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Sorry @leynos, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 2 days and 3 hours by commenting @sourcery-ai review. Upgrade to get a review now.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T18:27:16.842269Z 3755850 Draft marked ready
🔒 Security Review ✅ Completed 2026-11-03T18:27:50.836028Z 3755850 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@leynos
leynos merged commit 44eb13a into main Nov 3, 2026
4 checks passed
@leynos
leynos deleted the refresh-generated-typos-config branch November 3, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant