fix(fx-runtime): section-level data-fx never initialized - #26
Open
Ynchnnnn wants to merge 1 commit into
Open
Conversation
initFxIn/stopFxIn use root.querySelectorAll('[data-fx]'), which never
matches the root element itself — so data-fx placed directly on a
<section class="slide"> (the documented way to give a cover slide a
canvas background) was silently ignored: no canvas, no handle in
__hpxActive.
Add fxEls() that includes the root when it carries data-fx, and use it
in both init and stop so lifecycle stays symmetric.
Verified: a cover slide with data-fx="starfield" now mounts its canvas
on activation and stops on leave; descendant [data-fx] behavior unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
initFxIn/stopFxInlook up effect targets withroot.querySelectorAll('[data-fx]')— butquerySelectorAllnever matches the root element itself. Sodata-fxplaced directly on a<section class="slide">(the natural way to give a cover slide a canvas background) was silently ignored: no canvas mounted, no handle in__hpxActive.Fix
Add a small
fxEls(root)helper that includes the root when it carriesdata-fx, and use it in bothinitFxInandstopFxInso the lifecycle stays symmetric.Verification
data-fx="starfield"now mounts its canvas on activation (__hpxActiveholds the handle) and stops when the slide leaves.[data-fx]elements behave exactly as before.🤖 Generated with Claude Code