Repository navigation
fix: keep the HERE key and queries out of Sentry spans - #43
Merged
Merged
Conversation
The HERE proxy called the global fetch, which Sentry wraps on the first request, so every /geocode and /autocomplete span and breadcrumb recorded the upstream URL: the API key and what the user typed. Capture fetch at module load, as route planning, APNs, FCM, and analytics already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HERE proxy (
/geocode,/autocomplete) called the globalfetch. Sentry wraps that global on the first request, so every traced span and breadcrumb recorded the full upstream URL: the HERE API key (apiKey=) and what the user typed in the address search.src/proxy.tsnow capturesfetchat module load, before Sentry wraps it, the same way route planning, APNs, FCM, and analytics already do.Tests: the proxy and per-IP limit tests install a HERE stub before the worker is imported, and a new test checks that the proxy never calls the instrumented global.
Verification:
pnpm test(736 passing),tsc --noEmit, and the verify loop with a realHERE_API_KEY:/geocodeand/autocompletee2e both pass.After merge: rotate the HERE key, since past spans already hold the current one.
🤖 Generated with Claude Code