Address mise-uv-init.py recursive bug#105
Open
glen-level12 wants to merge 4 commits into
Open
Conversation
Member
|
There are no tests for the specific use case of using shim based activation of mise, which is why we didn't have any test failures yet up to this point. It would be a good idea to review the tests to see how hard it would be to work that test case into them. I'm not sure how deep I've buried the current mise execution paradigm into the test helpers. |
rsyring
requested changes
Jun 9, 2026
| # Matches the exact line older versions of the template emitted in ruff.toml: | ||
| # target-version = 'py313' | ||
| # Stripping it lets ruff auto-derive the target from pyproject.toml's `requires-python`. | ||
| LEGACY_RUFF_TARGET_VERSION_RE = re.compile(r"^target-version = 'py\d+'\n", re.MULTILINE) |
Member
There was a problem hiding this comment.
I don't think you need this. If you remove the line from ruff.toml copier will apply that change on update.
Explicit migration steps are only needed if something outside of template file adjustments are needed.
But this change to the ruff config should just be a template file adjustments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mise-uv-init.pyresults in recursive error loop? #104