Improve icon rendering on macOS - #141
Merged
Merged
Conversation
Owner
|
This looks good. I see the build script refers to |
Collaborator
Author
Yeah, I've been playing in the separate branch to add support for both xetex and luatex. I've called it texpresso-eclipse, but for now it still needs polishing and more I/O wiring, but I think this year it will be ready. Will remove it from macOS build script for now though. |
merv1n34k
force-pushed
the
fix/icon-padding
branch
2 times, most recently
from
July 4, 2026 16:29
88fdac5 to
373ee94
Compare
SDL_SetWindowIcon on macOS scales the bitmap to fill the dock cell, ignoring transparent padding. Only AppIcon.icns loaded via the bundle gets HIG layout. - Pad v3.svg viewBox so the artwork is 80% of the canvas. - Regenerate logo_blob.inc (used as window icon on Linux). - Skip SDL_SetWindowIcon on Apple so the bundle icon takes effect. - Add scripts/build-macos-app.sh + `make macos-app` target. Run `make macos-app`, then `open build/TeXpresso.app --args /abs/path.tex`.
merv1n34k
force-pushed
the
fix/icon-padding
branch
from
July 4, 2026 16:33
373ee94 to
7beac97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
SDL_SetWindowIconon macOS scales the bitmap to fill the dock cell, ignoring transparent padding. OnlyAppIcon.icnsloaded via the bundle gets HIG layout.I have changed the size of the logo and added a target for macOS to create an
.appbundle.Note, that with this PR to render an icon on macOS, one have to run
make macos-appand then eitheropen build/TeXpresso.app --args /abs/path.texor point tobuild/TeXpresso.app/Contents/MacOS/texpresso. Usingbuild/texpresso...will fallback to default macOS binary icon. Linux/Windows are unaffected.