CTP-5320 mail not sent - #1
Open
opitz wants to merge 12 commits into
Open
Conversation
|
don't merge as this branch is for PR lsuonline#102 and we already have a PR for this other issue. I'll use the ucl-isd branch for the build |
Replace calls to update_system_config_value() with the core set_config() function as the former did not invalidate the cache when setting values resulting in changed values not taking effect.
Migrate from deprecated assertObjectHasAttribute() to assertObjectHasProperty().
Previously PHPUnit tests used '1' for course and user IDs when creating message objects. But commit a382639 updated block_quickmail\persistents\message->get_message_recipients() adding a check that recipients are enrolled on the course, so bogus values no longer work for tests that result in this method being called. So where necessary we use the data generator to create test users and enrol them on courses.
- revoked my previous changes - included PR lsuonline#110
opitz
force-pushed
the
CTP-5320-mail-not-sent
branch
from
November 14, 2025 12:14
c529a75 to
d8359f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to send a message to a null user fails.
I amended the query to only process messages where the user_id is not null.