Skip to content

Add all rules from leon app#3

Merged
svenjacobs merged 8 commits into
leon-cleaning-services:mainfrom
rsb-23:rules-json
Jul 7, 2025
Merged

Add all rules from leon app#3
svenjacobs merged 8 commits into
leon-cleaning-services:mainfrom
rsb-23:rules-json

Conversation

@rsb-23

@rsb-23 rsb-23 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor
  • Test count increased to 53.
  • Modified RulesTest.kt to skip tests that are not working.
  • there are 5 skipped tests in total
  • yahoo search is split into two rules.

- Modified RunTest to skip tests that are not working.
- there are 5 skipped tests in total
- yaho search is split into two rules
@rsb-23

rsb-23 commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

@svenjacobs
Please review and let me know of any changes.

@svenjacobs svenjacobs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment.

Comment thread lib/src/jvmTest/kotlin/mathilda/RulesTest.kt Outdated

@svenjacobs svenjacobs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the JSON with the four existing rules and remove the "skip" parameter.

@rsb-23

rsb-23 commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

Yes, above 2 tests are working after merging new changes.
Other 3 domains are -

  • jodel : needs custom rule.
  • linksynergy : www should be removed from Domain.matchRegex, it complicates subdomain matching. FIXED
  • youtube : "Unmodified" cases can't be tested, hence removed it. FIXED

@rsb-23
rsb-23 requested a review from svenjacobs July 6, 2025 13:22
@svenjacobs

Copy link
Copy Markdown
Contributor

Yes, above 2 tests are working after merging new changes. Other 3 domains are -

  • jodel : needs custom rule.

In PR #5 I reworked the slot syntax. We can now specify some optional operations. The Jodel sanitizer is now possible with:

"jodel": {
  "type": "transform",
  "input": "data=([^?&]+)",
  "output": "{{1:urldecode:base64decode:jsonvalue($android_url)}}"
}

I already added jodel in this PR.

@rsb-23

rsb-23 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Fixed all

@svenjacobs svenjacobs self-assigned this Jul 7, 2025
@svenjacobs svenjacobs added the enhancement New feature or request label Jul 7, 2025

@svenjacobs svenjacobs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a few issues with the JSON.

Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
Comment thread lib/rules.json
@rsb-23

rsb-23 commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Rules applicable to all domains:

  • at_analytics
  • cx_analytics
  • empty_parameters
  • facebook_analytics
  • google_analytics
  • salesforce_parameters
  • session_ids
  • webtrekk

@rsb-23
rsb-23 requested a review from svenjacobs July 7, 2025 13:06

@svenjacobs svenjacobs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@svenjacobs
svenjacobs merged commit 314a0dc into leon-cleaning-services:main Jul 7, 2025
1 check passed
@rsb-23
rsb-23 deleted the rules-json branch July 7, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants