Repository navigation
labels.json: drop the unread ensure field and its validator rule - #302
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Review (haiku, claude-review.yml)No significant issues found. The I could not run |
Contributor
terraform plan (success) |
Contributor
Author
Review triageThe review reported no findings, so there's nothing to triage. Terraform plan on this PR: Arming auto-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #300
Summary
Removes the
ensureboolean from every entry infleet-ops/labels.json, and removes theci/validate.pyrule that required it. The field encoded "create the label where missing" (true) and "align only where it already exists" (false). Those were the semantics offleet-apply.sh --apply-labels, which #301 removed. Nothing has read the field since, but the validator still made every label carry a value with no effect.Confirmed unread before deleting
terraform/:locals.tfbuildsrepo_labelsfrom each label'sname,coloranddescriptiononly. It picks themodel:*routing labels by name prefix (startswith(label.name, "model:")) and the repo'smodel_labelslist, never byensure.labels.tf's only mention was a comment saying the module doesn't read it.ci/: the one reader wascheck_label_palette's explicit-boolean assertion, removed here.ensureacross*.tf,*.py,*.sh,*.ymland*.json(excluding history underfleet-reports/and the gitignoredarchive/) found no other consumer.Changes
fleet-ops/labels.json:ensuredropped from all 15 labels, so each is now exactlyname,color,description. The_commentparagraph describingensureis replaced by one sentence on how routing labels are opted in.ci/validate.py: theensureassertion is removed. Thecheck_label_palettedocstring now namesterraform/labels.tfas the consumer (it still saidgh label edit).fleet-ops/README.md: the labels section no longer describesensure, and the validator-shape sentence lists what it actually checks.terraform/labels.tf: the header comment is now in the past tense ("once carried … dropped in labels.json: drop the unread ensure field and its validator rule #300").Testing
python3 ci/validate.pypasses.#bb4a33color onbugproducedconfigs: fleet-ops/labels.json[0] ('bug'): color must be 6 hex digits without '#', and the file was then restored.jqparseslabels.json, every label has exactlycolor,description,name, andterraform fmt -checkis clean.🤖 Generated with Claude Code