Repository navigation
Retire lentago/coderabbit (ADR-0013 step 3) - #284
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1KkpsJ63gCUyCqLWiv
Contributor
terraform plan (failure) |
24 of 25 tasks
Contributor
Review (haiku, claude-review.yml)Review of PR #284 (Retire lentago/coderabbit, ADR-0013 step 3) I could not run
Checked and consistent, with no finding raised:
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SjEL1KkpsJ63gCUyCqLWiv
Contributor
Author
|
Review triage (Haiku CI, run 40979045987):
The plan fails only on |
Contributor
terraform plan (failure) |
Contributor
terraform plan (success) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283. Part of #276, step 3.
Summary
ADR-0013 replaced CodeRabbit with the fleet's own Haiku reviewer. All 17 operating repos now carry a working
claude-review.ymlcaller (step 2 of #276), so CodeRabbit's central-config repo has nothing left to configure. This PR retireslentago/coderabbitby the procedure interraform/README.md, "Retiring a repo": archive the repo, then remove it fromrepos.json,required-checks.jsonandbrand/fleet.json, andterraform state rmits resources right before the merge.What changes:
fleet-ops/repos.json,fleet-ops/required-checks.json,brand/fleet.json: thecoderabbitentries are removed. Only those blocks are cut, with no reformatting.brand/generated/coderabbit/: the generated banner, OG card and readme block are deleted, since the repo leaves the brand map.terraform/README.md: the per-repo resource count in the transfer note is corrected from twelve to fourteen, because ADR-0013 added two labels.python3 -I ci/validate.pypasses (configs, fleet, brand, census, register).ADR-0013 Decision 5 also lists turning off auto-review in the central
.coderabbit.yaml. That step is superseded: uninstalling the app stops all CodeRabbit activity at once, and the archived repo is read-only, so editing its config first would only add a PR to a repo that is closing.This PR's plan fails until the state removal, by design
github_repository.fleetcarriesprevent_destroy. Until the coderabbit resources leave state, this PR's plan proposes destroying them and stops on that guard, so thegatecheck fails and the PR can't merge early. That's the interlock the README describes.Steps for an org admin, in this order
gh repo archive lentago/coderabbit --yesterraformworkflow. The plan must show no changes. Then merge, and the apply is a no-op.🤖 Generated with Claude Code
https://claude.ai/code/session_01SjEL1KkpsJ63gCUyCqLWiv