Skip to content

Add PTY support for interactive script execution - #319

Merged
lemoony merged 3 commits into
mainfrom
feature/pty-support
Dec 4, 2025
Merged

Add PTY support for interactive script execution#319
lemoony merged 3 commits into
mainfrom
feature/pty-support

Conversation

@lemoony

@lemoony lemoony commented Dec 4, 2025

Copy link
Copy Markdown
Owner

No description provided.

@lemoony lemoony added the enhancement New feature or request label Dec 4, 2025
@codecov

codecov Bot commented Dec 4, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.21053% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.12%. Comparing base (cbf7410) to head (2bba4cc).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/app/app_exec.go 84.21% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   60.00%   60.12%   +0.11%     
==========================================
  Files         124      124              
  Lines        7294     7330      +36     
==========================================
+ Hits         4377     4407      +30     
- Misses       2763     2766       +3     
- Partials      154      157       +3     
Flag Coverage Δ
Linux 59.94% <84.21%> (+0.11%) ⬆️
macOS 60.09% <84.21%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Refactor terminal operations (GetSize, MakeRaw, Restore) into mockable
function variables to enable better testing of PTY execution paths.
Add tests for terminal size and raw mode error handling scenarios.
@lemoony
lemoony merged commit 511d98c into main Dec 4, 2025
7 checks passed
@lemoony
lemoony deleted the feature/pty-support branch December 4, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant