Fix ROCm version detection picking up TheRock -tests- builds#120
Merged
Conversation
danielholanda
marked this pull request as ready for review
July 9, 2026 20:50
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TheRock now publishes an extra test-build tarball (
e.g. therock-dist-linux-gfx103X-all-tests-7.15.0a20260709.tar.gz) that shares the same prefix and date as the real build, so the "latest" selection could pick it and then fail version extraction, breaking every Linux and Windows target. This anchors the file match so the version must come immediately after the prefix, excluding the-tests-variant. Verified against the live index for all targets on both OSes.