Repository navigation
Add tiered ROCm build-correctness and GPU inference qualification, and pin each release to one upstream commit - #29
Draft
sreeram-11 wants to merge 3 commits into
Conversation
…d pin each release to one upstream commit
sreeram-11
marked this pull request as draft
October 13, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds build-correctness and GPU inference checks for the ROCm artifacts, and pins each release to a single upstream commit.
Today the only verification of a ROCm build is one step asking whether a file matching
ggml-hip*.dllexists, on Windows only. That passes for a DLL containing zero GPU code, and there is no equivalent check on Linux at all.This matters because a broken ROCm build does not look broken.
Changes
.github/qualify-rocm/: 11 static checks on the published archive, and 5 GPU inference checks on the gfx1151 runners.llama-serveron a real GPU and asserts the GPU actually did the work, rather than just that the server replied.patchelf), which the CUDA and OpenVINO builds already did.checksums.txtand a per-archive qualification record to each release.Gating
New files
tier0_static.pytier1_gpu.pyllama-serveron a real GPU and exercises it over HTTPbinfmt.pyinstall_rocm.pycheck_post_merge.pyaggregate.pyreport.pyREADME.mdPer-check detail is in
.github/qualify-rocm/README.md.Important points to know
These came out of running the checks against a real published release:
libggml-hip.soshipped with the CI runner's absolute path in its library search pathCMAKE_ARGS, so its zip ships 27 upstreamtest-*.exebinariesCost
Tier 0 runs 6 legs on standard runners, including on PRs.
Tier 1 runs 6 legs on the two gfx1151 machines.