feat(fetcher): bind upstream URL and fetch time into commitment#704
Merged
Conversation
Commit `{ request: { url, fetchedAt, date }, response: { body } }` under
data-commitment-v1, and reshape FetchResult to `{ request, response,
commitment }`. Update feeds at the shared FetchResult boundary so forex
worker consumers and feed sources keep typechecking.
Co-authored-by: aggre <hiroyuki.aggre@gmail.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
fetcher | 6236016 | Commit Preview URL Branch Preview URL |
Jul 26 2026, 01:58 PM |
Align the committed payload field with the data being committed, rather than HTTP-body terminology. Co-authored-by: aggre <hiroyuki.aggre@gmail.com>
aggre
marked this pull request as ready for review
July 26, 2026 13:51
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Sync fetcher-request-binding requirements into main specs and move the completed change under changes/archive/. Co-authored-by: aggre <hiroyuki.aggre@gmail.com>
Production fetcher still returns top-level `data`; read either `response.data` or legacy `data` so forex feeds and registry tests work across deploy order. Co-authored-by: aggre <hiroyuki.aggre@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetchAndCommitnow commits{ request: { url, fetchedAt, date }, response: { data } }via existingdata-commitment-v1/commitDeep(no new circuit).FetchResultis reshaped to{ request, response: { data, canonical }, commitment }.packages/feedsupdated at the sharedFetchResultboundary (data→response.data, etc.). Feed-localcommitDeeppayloads (scaled forex, compact snapshots) are unchanged.Feeds impact
FetchResultis theFeedSourcecontract, so the type change does touch feeds. Scope was kept to envelope field access / construction only — commitment semantics inside each feed stay the same. Forex feeds that call the fetcher Workers API now readfetched.response.data.Test plan
pnpm --filter @lemmaoracle/fetcher test(8 passed)pnpm --filter @lemmaoracle/fetcher type-checkpnpm --filter @lemmaoracle/fetcher lintpnpm --filter @lemmaoracle/feeds type-checkpnpm --filter @lemmaoracle/feeds lint