Skip to content

feat(seal): add vkey to IPFS registration + data-commitment circuit#671

Open
aggre wants to merge 2 commits into
mainfrom
fix/ci-build-step
Open

feat(seal): add vkey to IPFS registration + data-commitment circuit#671
aggre wants to merge 2 commits into
mainfrom
fix/ci-build-step

Conversation

@aggre

@aggre aggre commented Jul 15, 2026

Copy link
Copy Markdown
Member

Changes

seal/register-circuit.ts

  • Upload vkey to IPFS via Pinata alongside wasm/zkey
  • CIRCUIT_ID bumped to seal-identity-v2.1
  • vkey URL included in CircuitMeta artifact location
  • All three artifacts (wasm, zkey, vkey) must exist before registration

data-commitment circuits

  • Build infrastructure for data-commitment-v1: Poseidon Merkle tree commitment over arbitrary JSON
  • Mux1-based MerkleProofChecker for circom 2.2.3 compatibility
  • 8,909 constraints, PTAU 2^15

Why

Previously seal-identity-v1 was registered without a vkey URL — the vkey was bundled locally in the dashboard/API. The verify endpoint requires vkey to be fetchable from the artifact location, so seal sign-ins routed through POST /v1/proofs/verify failed.

Now the script uploads all three artifacts to IPFS, making the circuit registration self-contained.

aggre added 2 commits July 15, 2026 00:07
pnpm-lock.yaml was bumped to 8.64.0 in #667 but package.json stayed
at 8.63.0, causing --frozen-lockfile CI failures on all PRs.
packages like @lemmaoracle/sdk need dist/ built before dependents
like data-commitment can import them. CI had no build step between
install and test, so sdk/dist was missing in clean environments.
@aggre
aggre force-pushed the fix/ci-build-step branch from bd5b019 to db1603f Compare July 15, 2026 00:27
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jul 15, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
mcp db1603f Jul 15 2026, 12:28 AM

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying schemas with  Cloudflare Pages  Cloudflare Pages

Latest commit: db1603f
Status: ✅  Deploy successful!
Preview URL: https://4213e643.schemas-a8x.pages.dev
Branch Preview URL: https://fix-ci-build-step.schemas-a8x.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying demo with  Cloudflare Pages  Cloudflare Pages

Latest commit: db1603f
Status: ✅  Deploy successful!
Preview URL: https://6d2d7ab9.lemma-1ri.pages.dev
Branch Preview URL: https://fix-ci-build-step.lemma-1ri.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying web with  Cloudflare Pages  Cloudflare Pages

Latest commit: db1603f
Status: ✅  Deploy successful!
Preview URL: https://574dd36c.web-zgj.pages.dev
Branch Preview URL: https://fix-ci-build-step.web-zgj.pages.dev

View logs

@aggre

aggre commented Jul 22, 2026

Copy link
Copy Markdown
Member Author

🤖 Autonomous improver — stale PR flag (2026-07-22)

This PR has been inactive for 7 days (last push: 2026-07-15) and has:

  • Merge conflicts (mergeable: false, state: dirty)
  • CI test checks: all FAILED (4 test runs on 2026-07-15)

The branch name is fix/ci-build-step and the diff touches seal circuit registration + data-commitment circuit infrastructure (circuit files + seal/register-circuit.ts).

Suggested actions:

  • Rebase against main and resolve merge conflicts
  • Investigate the 4 failing test CI runs — likely the same root cause
  • If the data-commitment circuit work has been superseded, consider closing this PR

Since this PR touches circuit files, it is outside the autonomous pipeline's scope — flagging for human review only.


Posted by lemma-autonomous-improver cron (VPoE pipeline)

@aggre

aggre commented Jul 25, 2026

Copy link
Copy Markdown
Member Author

CI failure diagnosis

The Build workspace packages step is failing because this PR adds build and type-check scripts to packages/attestation/package.json:

"build": "tsc -p tsconfig.json",
"type-check": "tsc --noEmit",

However, packages/attestation/ is a circuit-only package — it has no src/ directory and no tsconfig.json. The CI error confirms this:

packages/attestation build: error TS5058: The specified path does not exist: 'tsconfig.json'.

On main, attestation correctly has no build script (only build:circuit, test, test:circuit), so pnpm -r build skips it.

Options to fix

  1. Remove the build and type-check scripts from attestation — it is circuit-only, same pattern as packages/roles and packages/blog-article which also have no build script. The pnpm -r build step will skip it.
  2. Add a tsconfig.json if the intent is to type-check the circuits' TypeScript helper scripts — but note there is no src/ dir today.

(Posted by autonomous improver cron — flagging the stale CI, not modifying the PR.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant